Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space around dots when negative floats are inside Expr.TripleNumberIndexRange #3106

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add space around dots when negative floats are inside Expr.TripleNumberIndexRange #3106

merged 1 commit into from
Aug 16, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Aug 16, 2024

Fixes #3105

@nojaf nojaf requested a review from dawedawe August 16, 2024 07:42
@dawedawe
Copy link
Member

Reviewing on my phone due to traveling, but looks good 👍

@nojaf nojaf merged commit f4738e0 into fsprojects:main Aug 16, 2024
5 checks passed
@nojaf
Copy link
Contributor Author

nojaf commented Aug 16, 2024

Thanks, we can always revisit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawedawe dawedawe dawedawe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F# Range Operator (..) with negative numbers produces invalid F# code and idempotent
2 participants
@nojaf @dawedawe